-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Kernel Compiler OpenCL ext_can_compile rejects older ocloc #18170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cperkinsintel
wants to merge
14
commits into
intel:sycl
Choose a base branch
from
cperkinsintel:cperkins-can-compile-rejects-older-ocloc
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[SYCL] Kernel Compiler OpenCL ext_can_compile rejects older ocloc #18170
cperkinsintel
wants to merge
14
commits into
intel:sycl
from
cperkinsintel:cperkins-can-compile-rejects-older-ocloc
+100
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears to:
- Add a fallback on Windows that checks for an ocloc DLL in a fixed location, if one isn't found using standard DLL search orders.
- Performs an ocloc query when loading the ocloc DLL as a test to determine that the ocloc library is "good".
Both of these changes are improvements over the existing code, hence my review approval, but I think we ought to reconsider how we handle this in the future. For example:
- Can we handle the case where the user installs into a non-standard directory and hence the ocloc DLL isn't found at the fixed location?
- When there are multiple devices in the system, are there cases where we may need multiple ocloc libraries? Should the ocloc library handle be tied to the SYCL context (or perhaps the SYCL device, or the SYCL platform) rather than stored in a single static global variable?
- Can we add some encapsulation so this code is easier to understand and maintain in the future?
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
495d6b8
to
6964838
Compare
Signed-off-by: Chris Perkins <[email protected]>
…different PR Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Kernel Compiler Open CL C support the
device.ext_can_compile
now passes the device down so we can make sure OCLOC supports commands with the -dev IPVersionStr .